Merged
Conversation
Collaborator
Author
|
@CohenCyril mentioned that |
Collaborator
Author
|
I am not convinced that we want all the changes, I can add the time saved be each change if this helps the decision making. |
Collaborator
Author
|
Fun fact: ~16% of the total compilation time is spent on HB commands and ~27% is spent importing things. |
affeldt-aist
approved these changes
Dec 20, 2024
zstone1
approved these changes
Dec 20, 2024
Contributor
zstone1
left a comment
There was a problem hiding this comment.
Thank you for doing this! Happy to see these improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
There are a few lines that take a long time to compile (up to 12s). This PR takes every line that takes above 1s to compile and that is not an import or an HB command and rewrites it in less than a second (when I could). This saves overall 7% of the compilation time (with most of the time save (-29%) in
lebesgue_integral.v).Checklist
CHANGELOG_UNRELEASED.mdReference: How to document
Reminder to reviewers